Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for the indexmap crate. #25

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Add support for the indexmap crate. #25

merged 2 commits into from
Sep 13, 2024

Conversation

de-vri-es
Copy link
Contributor

@de-vri-es de-vri-es commented Sep 13, 2024 •
edited
Loading

This PR implements optional support for the indexmap crate as requested in #24.

@de-vri-es de-vri-es mentioned this pull request Sep 13, 2024
Open
hgaiser
hgaiser approved these changes Sep 13, 2024
View reviewed changes
Copy link

@hgaiser hgaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though why do we want to use indexmap ?

@de-vri-es
Copy link
Contributor Author

@SamuelMarks wants to: #24

And I think it makes sense. indexmap is a popular and useful map.

@de-vri-es de-vri-es merged commit 2a5cc1a into main Sep 13, 2024
2 checks passed
@hgaiser hgaiser deleted the indexmap branch September 13, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hgaiser hgaiser hgaiser approved these changes

@dan-jfisher dan-jfisher Awaiting requested review from dan-jfisher

@ekrikelis ekrikelis Awaiting requested review from ekrikelis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@de-vri-es @hgaiser