Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relocate RP socket to xdg-run/app/appid directory #68

Merged
merged 2 commits into from
May 29, 2019

Conversation

gasinvein
Copy link
Member

@gasinvein gasinvein commented May 17, 2019

Change socket location from $XDG_RUNTIME_DIR/discord/ipc-0 to $XDG_RUNTIME_DIR/app/com.discordapp.Discord/discord-ipc-0.
This way the exported Discord RPC socket would keep it's original name (discord-ipc-0) and the already-existing xdg-run/app/appid directory would be reused.
KeePassXC takes similar approach: it puts socket under xdg-run/app/appid, I find it much better than the original approach I took for Discord.

Apps that would need changes:

@flathubbot
Copy link
Contributor

Started test build 3527

@flathubbot
Copy link
Contributor

Build 3527 failed

@flathubbot
Copy link
Contributor

Started test build 3529

@flathubbot
Copy link
Contributor

Build 3529 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/3371/com.discordapp.Discord.flatpakref

@gasinvein gasinvein changed the title Avoid renaming RPC socket, use xdg-run/app/... directory Relocate RP socket to xdg-run/app/appid directory May 17, 2019
@TingPing TingPing merged commit f901736 into flathub:master May 29, 2019
@TingPing
Copy link
Member

Don't forget to update wiki.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants