Only warn if SIGNAL_PASSWORD_STORE is unset.

[F-i-f]

If a user already has set a flatpak override defining SIGNAL_PASSWORD_STORE to basic, there is no point showing them a warning.

[salim-b]

Yes it is, because basic is less secure. But OS keystore support can likely be enabled by default again once #756 is merged.

[flathubbot]

Started test build 151195

[flathubbot]

Build 151195 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/134282/org.signal.Signal.flatpakref

[bermeitinger-b]

The default value of SIGNAL_PASSWORD_STORE not being empty but the value basic. With your patch, the warning would never show.

If the integration into the keyring works, we can set it to empty by default.

[F-i-f]

The default value of SIGNAL_PASSWORD_STORE not being empty but the value basic. With your patch, the warning would never show.

Not exactly.
If SIGNAL_PASSWORD_STORE is not set by the user via flatpak override, then the warning will show.
If SIGNAL_PASSWORD_STORE is set to any value (including basic) then the warning will not show.

If the integration into the keyring works, we can set it to empty by default.

Which would be best.

[bermeitinger-b]

But the value is by default set to basic. It is never empty.

[flathubbot]

Started test build 151623

[F-i-f]

Apologies, you are correct, I had missed that the variable is set by default in the environment.
This patch should take care of it.

[flathubbot]

Build 151623 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/134706/org.signal.Signal.flatpakref

[bermeitinger-b]

Thanks for the modification. The change you proposed is the default by upstream Signal. (Use the default password store). Then we can remove the warning altogether (upstream also does not "warn" the users about basic encryption).