Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support angles greater 2π in EquiangularPolygons #170

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Support angles greater 2π in EquiangularPolygons #170

wants to merge 9 commits into from

Conversation

saraedum
Copy link
Member

No description provided.

@videlec
Copy link
Collaborator

videlec commented Jun 10, 2022

Even though it works in some cases, going via EquiangularPolygons will not generalize well (because two boundaries could give rise to two different flat disks).

@davidaulicino
Copy link

I think it's great that it can handle any polygons with angle greater than 2pi. Do you have any idea of the scope of it's functionality at the moment? Can it handle all polygons with one angle larger than 2pi? Does a problem arise when you get to 7-gons and an angle greater than 4pi is possible?

@saraedum
Copy link
Member Author

This is only a hack to show that the approach we discussed works in principle. This still needs some architectural work the result might be that EquiangularPolygons is the wrong place.

I would imagine that an angle >4pi is easier than two angles >2pi but I have not tried.

@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: 3301595

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saraedum @videlec @davidaulicino