Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix about screen #2907

Merged
merged 3 commits into from
Aug 2, 2023
Merged

Fix about screen #2907

merged 3 commits into from
Aug 2, 2023

Conversation

andzhr
Copy link
Contributor

@andzhr andzhr commented Jul 20, 2023 •
edited by skotopes
Loading

What's new

  • fix bug with display of the radio equipment certification number together with other certificates (description is in issue - Bug in displaying certificates #2904)
  • fix condition in about_settings_app

Verification

  • check that the certificate number from the previous page is no longer displayed together with other certificates (reproduction is described in issue - Bug in displaying certificates #2904)

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@hedger hedger added Bug UI Affects UI labels Jul 21, 2023
@skotopes skotopes merged commit 7a45db3 into flipperdevices:dev Aug 2, 2023
8 checks passed
agarof pushed a commit to agarof/flipperzero-firmware that referenced this pull request Aug 30, 2023
@andzhr @skotopes @agarof
Fix about screen (flipperdevices#2907)
6205917 
* Fix about screen
* About: use COUNT_OF

Co-authored-by: Andrey Zakharov <andzhr@yandex.ru>
Co-authored-by: あく <alleteam@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

Assignees
No one assigned
Labels
Bug UI Affects UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andzhr @skotopes @hedger