Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix display last symbol in multiline text #2967

Merged
merged 6 commits into from
Aug 22, 2023
Merged

Fix display last symbol in multiline text #2967

merged 6 commits into from
Aug 22, 2023

Conversation

Programistich
Copy link
Contributor

@Programistich Programistich commented Aug 10, 2023 •
edited by skotopes
Loading

What's new

  • Fix issue Name clipping during nfc emulation #2963
  • Now we are rounding to the whole part, but our text may be 0.4, as for example with "[AC] 008 - Timmy", which does not allow the transfer to a new line

Verification

  • Emulate NFC Classic / Ultralight with name "[AC] 008 - Timmy" and "[AC] 008 - TimmyO"

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@Programistich Programistich changed the title Fix last place display on NFC emulating Fix display last symbol display on NFC emulating Aug 10, 2023
@Programistich Programistich changed the title Fix display last symbol display on NFC emulating Fix display last symbol on NFC emulating Aug 10, 2023
@Programistich Programistich changed the title Fix display last symbol on NFC emulating Fix display last symbol in multiline text Aug 20, 2023
@hedger hedger added Bug UI Affects UI labels Aug 22, 2023
@skotopes skotopes merged commit dc7517e into flipperdevices:dev Aug 22, 2023
8 checks passed
@skotopes skotopes mentioned this pull request Aug 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gornekich gornekich Awaiting requested review from gornekich

@Astrrra Astrrra Awaiting requested review from Astrrra

Assignees
No one assigned
Labels
Bug UI Affects UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Programistich @skotopes @hedger