Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FL-3600] Added fal_embedded parameter for PLUGIN apps #3083

Merged
merged 8 commits into from
Sep 21, 2023
Merged

[FL-3600] Added fal_embedded parameter for PLUGIN apps #3083

merged 8 commits into from
Sep 21, 2023

Conversation

hedger
Copy link
Member

@hedger hedger commented Sep 14, 2023 •
edited by skotopes
Loading

What's new

  • fbt, ufbt: refactored external apps internal state management
  • fbt, ufbt: added fal_embedded parameter for PLUGIN apps, to embed them into .fap

Verification

  • set fal_embedded=True for a plugin in example_advanced_plugins
  • install app
  • observe the plugin in apps_assets

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions
Copy link

github-actions bot commented Sep 14, 2023 •
edited
Loading

Compiled f7 firmware for commit c5e30c2a:

@hedger hedger mentioned this pull request Sep 14, 2023
Closed
6 tasks
@hedger hedger changed the title [FL-3600] Added fal_embedded parameter for PLIGIN apps [FL-3600] Added fal_embedded parameter for PLUGIN apps Sep 19, 2023
skotopes
skotopes previously approved these changes Sep 21, 2023
View reviewed changes
@skotopes skotopes merged commit 1891d54 into dev Sep 21, 2023
8 of 9 checks passed
@skotopes skotopes deleted the hedger/3600-fal_embedded branch September 21, 2023 12:56
@hedger hedger added Build System & Scripts fbt, scripts and toolchain-related New Feature Contains an IMPLEMENTATION of a new feature labels Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@drunkbatya drunkbatya Awaiting requested review from drunkbatya drunkbatya is a code owner

Assignees
No one assigned
Labels
Build System & Scripts fbt, scripts and toolchain-related New Feature Contains an IMPLEMENTATION of a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hedger @skotopes