Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Furi: Fix EventLoop state persisting on same thread after free #3711

Merged
merged 3 commits into from
Jun 14, 2024
Merged

Furi: Fix EventLoop state persisting on same thread after free #3711

merged 3 commits into from
Jun 14, 2024

Conversation

Willy-JL
Copy link
Contributor

@Willy-JL Willy-JL commented Jun 14, 2024 •
edited by skotopes
Loading

What's new

  • Freeing view dispatcher then making new one on same thread would stop it instantly
  • This clears event loop notify state on free, so new view dispatcher / event loop is not affected by previous one
  • Not sure if this is fine in terms of rtos and safety, but it did resolve the symptoms

Verification

  • Free view dispatcher and alloc new one on same thread, both will run correctly

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@Willy-JL Willy-JL mentioned this pull request Jun 14, 2024
Closed
@skotopes skotopes merged commit 12c1d10 into flipperdevices:dev Jun 14, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

@gornekich gornekich Awaiting requested review from gornekich gornekich is a code owner

@Astrrra Astrrra Awaiting requested review from Astrrra Astrrra is a code owner

@Skorpionm Skorpionm Awaiting requested review from Skorpionm Skorpionm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Willy-JL @skotopes