Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lfrfid GProxII support #3796

Merged
merged 8 commits into from
Jul 31, 2024
Merged

Add lfrfid GProxII support #3796

merged 8 commits into from
Jul 31, 2024

Conversation

BarTenderNZ
Copy link
Contributor

@BarTenderNZ BarTenderNZ commented Jul 21, 2024 •
edited by skotopes
Loading

What's new

Adding support for the Guardall/Verex/Chubb GProx II rfid cards.
This can read and clone the cards. But the algorithm for the calculated XOR and CRC bits is not currently known.
Based this off the Iceman Proxmark3 fork cmdlfguard.c and added displaying XOR and CRC.

Verification

I am able to read, emulate a GProxII card and write it to a T5577

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

hedger
hedger previously requested changes Jul 21, 2024
View reviewed changes
Copy link
Member

@hedger hedger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run fbt format

@BarTenderNZ
Copy link
Contributor Author

Thanks @hedger I had missed fbt format in CODING_STYLE.md. Apologies.

@BarTenderNZ BarTenderNZ requested a review from hedger July 21, 2024 18:29
@hedger hedger added RFID 125kHz 125, 134 kHz RFID New Feature Contains an IMPLEMENTATION of a new feature labels Jul 22, 2024
@skotopes
Copy link
Member

@BarTenderNZ do you feel like this PR is ready to be merged?

@BarTenderNZ
Copy link
Contributor Author

BarTenderNZ commented Jul 31, 2024 •
edited
Loading

@BarTenderNZ do you feel like this PR is ready to be merged?

Yes, I just made one last commit now so the comments don't fail the linting workflow so no longer having XXXXXXXX for the XOR Value.

Should now in theory pass all linting tests.

Edit. Just passed all tests. 🚀

@skotopes skotopes merged commit bec6bd3 into flipperdevices:dev Jul 31, 2024
11 checks passed
@BarTenderNZ BarTenderNZ deleted the add_lfrfid_gproxii_support branch August 1, 2024 01:19
@austinscreations austinscreations mentioned this pull request Aug 9, 2024
Closed
@korden32 korden32 mentioned this pull request Aug 19, 2024
Closed
@zinongli zinongli mentioned this pull request Sep 9, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

@drunkbatya drunkbatya Awaiting requested review from drunkbatya drunkbatya is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

Assignees

@DrZlo13 DrZlo13

Labels
New Feature Contains an IMPLEMENTATION of a new feature RFID 125kHz 125, 134 kHz RFID
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BarTenderNZ @skotopes @hedger @DrZlo13