Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCID App: Refactor #3808

Merged
merged 2 commits into from
Jul 31, 2024
Merged

CCID App: Refactor #3808

merged 2 commits into from
Jul 31, 2024

Conversation

kidbomb
Copy link
Contributor

@kidbomb kidbomb commented Jul 26, 2024

What's new

  • Moved iso7816 related code to its own folder
  • Refactor Iso7816Callback into Iso7816Handler
  • Created new file for CCID commands
  • Renamed variables according to standard

Verification

  • Start CCID Test application
  • Run the ccid_client.py script under applications/debug/ccid_test/client
  • Select the 'Generic USB Smart Card Reader'
  • All tests should pass

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

 - Move iso7816 related code to its own folder
 - Refactor Iso7816Callback into Iso7816Handler
 - Created new file for CCID commands
 - Renamed variables according to standard
@hedger hedger added the Applications Non-core applications label Jul 26, 2024
@skotopes skotopes merged commit 53cf700 into flipperdevices:dev Jul 31, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Applications Non-core applications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants