[FL-3766] Refactor detected protocols list #3809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Compiled f7 firmware for commit |
Astrrra
requested review from
skotopes,
DrZlo13,
hedger,
gsurkov and
gornekich
as code owners
| instance->selected_idx = 0; | ||
| } | ||
|
|
||
| uint32_t nfc_detected_protocols_get_num(NfcDetectedProtocols* instance) { |
There was a problem hiding this comment.
Suggested change
| uint32_t nfc_detected_protocols_get_num(NfcDetectedProtocols* instance) { | |
| uint32_t nfc_detected_protocols_get_num(const NfcDetectedProtocols* instance) { |
| return instance->protocols_detected_num; | ||
| } | ||
|
|
||
| NfcProtocol nfc_detected_protocols_get_protocol(NfcDetectedProtocols* instance, uint32_t idx) { |
There was a problem hiding this comment.
Suggested change
| NfcProtocol nfc_detected_protocols_get_protocol(NfcDetectedProtocols* instance, uint32_t idx) { | |
| NfcProtocol nfc_detected_protocols_get_protocol(const NfcDetectedProtocols* instance, uint32_t idx) { |
| instance->selected_idx = 0; | ||
| } | ||
|
|
||
| NfcProtocol nfc_detected_protocols_get_selected(NfcDetectedProtocols* instance) { |
There was a problem hiding this comment.
Suggested change
| NfcProtocol nfc_detected_protocols_get_selected(NfcDetectedProtocols* instance) { | |
| NfcProtocol nfc_detected_protocols_get_selected(const NfcDetectedProtocols* instance) { |
gornekich
approved these changes
Jul 31, 2024
skotopes
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
Verification
Checklist (For Reviewer)