Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCID: App changes #3837

Merged
merged 2 commits into from
Sep 5, 2024
Merged

CCID: App changes #3837

merged 2 commits into from
Sep 5, 2024

Conversation

kidbomb
Copy link
Contributor

@kidbomb kidbomb commented Aug 12, 2024 •
edited by skotopes
Loading

What's new

  • Keep ccid_callback and buffer as private to the iso7816_handler
  • set usb ccid callback from iso7816_handler (to ensure the right structure is being passed)
  • make iso7816 related code independent from furi related code (goal is to make it independently testable)
  • rename vars

Verification

  • Start CCID Test application
  • Run the ccid_client.py script under applications/debug/ccid_test/client
  • Select the 'Generic USB Smart Card Reader'
  • All tests should pass

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@kidbomb
CCID: App changes
957e22e 
 - Keep ccid_callback and buffer as private to the iso7816_handler
 - set usb ccid callback from iso7816_handler (to ensure the right structure is being passed)
 - make iso7816 related code independent from furi related code (goal is to make it independently testable)
 - rename vars
@hedger hedger added the Applications Non-core applications label Aug 12, 2024
@skotopes skotopes merged commit 4a58930 into flipperdevices:dev Sep 5, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

Assignees
No one assigned
Labels
Applications Non-core applications
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kidbomb @skotopes @hedger