Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picopass more bit formats #47

Merged
merged 6 commits into from
Sep 25, 2023
Merged

Picopass more bit formats #47

merged 6 commits into from
Sep 25, 2023

Conversation

bettse
Copy link
Collaborator

@bettse bettse commented Sep 19, 2023

What's new

  • Remove parsing of 26 bit credentials since it didn't check parity and could have been wrong
  • Support more LFRFID formats for longer bit length credentials

Verification

  • Part 1. Scan a 26 bit credential, see that it shows the raw value and not a facility code or card number
  • Part 2. Scan a credential that is longer than 26 bits, see that you can save as LFRFID

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@bettse bettse marked this pull request as ready for review September 22, 2023 03:10
@bettse bettse marked this pull request as draft September 23, 2023 02:05
@bettse
Copy link
Collaborator Author

bettse commented Sep 23, 2023

converting to draft: I was porting the changes to seader and a 35bit card wasn't working as expected, so I want to check more credential sizes first

@bettse bettse marked this pull request as ready for review September 23, 2023 04:55
@bettse
Copy link
Collaborator Author

bettse commented Sep 23, 2023

Ready for review, it was just the differences in the "Data: xxx" that were throwing me, but LFRFID emulation and a proxmark show the expected data.

@skotopes
Copy link
Member

@bettse should I wait for changelog or it's ok to merge?

@bettse
Copy link
Collaborator Author

bettse commented Sep 25, 2023

ok to merge 👍 : we'll (probably) do a changelog + version bump PR after this. We might do one more, we're talking about maybe adding haptics to loclass.

@skotopes skotopes merged commit 3bc236c into flipperdevices:dev Sep 25, 2023
2 checks passed
@bettse bettse deleted the picopass_more_bit_formats branch September 25, 2023 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants