network: utils: Fix int conversion errors #8555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmo0920
force-pushed
the
cosmo0920-fix-int-conversion-errors
branch
from
253e4a4
to
fa77b43
Compare
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
out_size is just for used to return the lentgth of ID string. Removing this flb_free does not cause memory leaks. ``` % leaks -atExit -- bin/flb-it-utils test_flb_utils_get_machine_id flb-it-utils(34841) MallocStackLogging: could not tag MSL-related memory as no_footprint, so those pages will be included in process footprint - (null) flb-it-utils(34841) MallocStackLogging: recording malloc and VM allocation stacks using lite mode Test test_flb_utils_get_machine_id... [ OK ] SUCCESS: All unit tests have passed. Process 34841 is not debuggable. Due to security restrictions, leaks can only show or save contents of readonly memory of restricted processes. Process: flb-it-utils [34841] Path: /Users/USER/*/flb-it-utils Load Address: 0x1023cc000 Identifier: flb-it-utils Version: 0 Code Type: ARM64 Platform: macOS Parent Process: leaks [34840] Date/Time: 2024-03-06 23:42:29.641 +0900 Launch Time: 2024-03-06 23:42:29.596 +0900 OS Version: macOS 14.3.1 (23D60) Report Version: 7 Analysis Tool: /usr/bin/leaks Physical footprint: 4385K Physical footprint (peak): 4385K Idle exit: untracked ---- leaks Report Version: 4.0, multi-line stacks Process 34841: 516 nodes malloced for 42 KB Process 34841: 0 leaks for 0 total leaked bytes. ``` Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
cosmo0920
force-pushed
the
cosmo0920-fix-int-conversion-errors
branch
from
fa77b43
to
6ad9729
Compare
|
(I am glad I resisted to upgrade command line tools XD ) |
cosmo0920
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
|
Then, we should process reviewing! ;-) |
pwhelan
approved these changes
Mar 12, 2024
|
thanks! |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updated the latest command line tools, I got int conversion errors.
These should be generated using POSIX version of strerror_r and needless flb_free calling.
The latter one is able to be confirmed with:
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.