Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

processor_sql: Ensure jemalloc compiling before starting to build sql parser #8594

Merged

Conversation

cosmo0920
Copy link
Contributor

@cosmo0920 cosmo0920 commented Mar 18, 2024

flb_mem.h wants to depend on jemalloc when FLB_JEMALLOC is turned on.
jemalloc building order itself is mostly controlled by target_link_libraries(fluent-bit-static libjemalloc). However, processor-sql-parser library does not have such dependency indication of jemalloc.
This should be lack of information for building order after the bundled jemalloc is built.
This PR fixes the order glitch.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

flb_mem.h wants to depend on jemalloc when FLB_JEMALLOC is turned on.

Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
@cosmo0920 cosmo0920 force-pushed the cosmo0920-add-jemalloc-dependency-on-sql-parser-for-processor branch 2 times, most recently from 8287b1b to 3fd5810 Compare March 19, 2024 05:07
@cosmo0920 cosmo0920 changed the title processor_sql: Add jemalloc dependency on sql parser processor_sql: Ensure jemalloc compiling before starting to build sql parser Mar 19, 2024
@edsiper edsiper merged commit 401620b into master Mar 19, 2024
70 checks passed
@edsiper edsiper deleted the cosmo0920-add-jemalloc-dependency-on-sql-parser-for-processor branch March 19, 2024 13:53
@edsiper
Copy link
Member

edsiper commented Mar 19, 2024

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants