Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in_kubernetes_filter: add namespace_metadata_only option to fix regression from #8279 #8695

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

ryanohnemus
Copy link
Contributor

@ryanohnemus ryanohnemus commented Apr 9, 2024

fix regression in 3.0 from #8279

fixes #8642

Adds a new namespace_metadata_only config option that is off by default. When this option is enabled it allows you to fetch only namespace metadata without also having to fetch pod metadata.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

fluent/fluent-bit-docs#1352

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

fix regression in 3.0 from fluent#8279

Signed-off-by: ryanohnemus <ryanohnemus@gmail.com>
@ryanohnemus
Copy link
Contributor Author

ryanohnemus commented Apr 10, 2024

@edsiper this should be ready to go, I did a few different configuration tests and they should hopefully resolve the regression. Can we add the safe for CI test flags to this one? That should give us an extra check now that there are some kubernetes plugin CI tests added :)

@edsiper edsiper added this to the Fluent Bit v3.0.2 milestone Apr 10, 2024
@edsiper
Copy link
Member

edsiper commented Apr 10, 2024

thanks for working on this in a timely manner, I will go ahead and merge it now, definitely we need to think how to test this in our CI (any idea is welcome)

@edsiper
Copy link
Member

edsiper commented Apr 11, 2024

FYI: changing the commit prefix to filter_kubernetes: ...

@edsiper edsiper merged commit 1233c16 into fluent:master Apr 11, 2024
48 checks passed
lecaros pushed a commit to fluent/fluent-bit-docs that referenced this pull request Apr 17, 2024
Signed-off-by: ryanohnemus <ryanohnemus@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kubernetes Metadata is not working with Fluent Bit 3.0.0
2 participants