Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http_server: Fix keep-alive for HTTP/1.1 requests #8761

Merged
merged 7 commits into from
Apr 30, 2024

Commits on Apr 25, 2024

  1. http_server: fix keep-alive for http/1.1 requests

    This patch moves the initialisation of a HTTP/1.1 stream from the
    session initialisation to the session ingestion step.
    
    Previously, using keep-alive on HTTP/1.1 would panic on the second
    request, as it would attempt to use components like the header map that
    are destroyed after each stream, but only initialised at the start of
    the session, when the HTTP protocol autodetection was run.
    
    Signed-off-by: Andrew Titmuss <iandrewt@icloud.com>
    iandrewt committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    0ef074a View commit details
    Browse the repository at this point in the history
  2. in_http: enable keep-alive

    This patch stops the forced connection-close for requests that aren't
    HTTP/2 on the in_http plugin
    
    Signed-off-by: Andrew Titmuss <iandrewt@icloud.com>
    iandrewt committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    1237eff View commit details
    Browse the repository at this point in the history
  3. in_elasticsearch: enable keep-alive

    This patch stops the forced connection-close for requests that aren't
    HTTP/2 on the in_elasticsearch plugin
    
    Signed-off-by: Andrew Titmuss <iandrewt@icloud.com>
    iandrewt committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    61b5928 View commit details
    Browse the repository at this point in the history
  4. in_opentelemetry: enable keep-alive

    This patch stops the forced connection-close for requests that aren't
    HTTP/2 on the in_opentelemetry plugin
    
    Signed-off-by: Andrew Titmuss <iandrewt@icloud.com>
    iandrewt committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    2890b8c View commit details
    Browse the repository at this point in the history
  5. in_splunk: enable keep-alive

    This patch stops the forced connection-close for requests that aren't
    HTTP/2 on the in_splunk plugin
    
    Signed-off-by: Andrew Titmuss <iandrewt@icloud.com>
    iandrewt committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    3a2f91f View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. http_server: initialize request in process_request for http/1.1

    This patch addresses feedback from @leonardo-albertovich, reducing how
    many components are being recreated on each new request for a single
    session. Now it only recreates the request object, rather than creating
    a new stream for each request of a session.
    
    It replaces my original fix in 0ef074a
    
    Signed-off-by: Andrew Titmuss <iandrewt@icloud.com>
    iandrewt committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    d0911e5 View commit details
    Browse the repository at this point in the history
  2. http_server: fix formatting of if/else block

    Signed-off-by: Andrew Titmuss <iandrewt@icloud.com>
    iandrewt committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    4020f68 View commit details
    Browse the repository at this point in the history