dockerfiles: Add FLB_ENFORCE_ALIGNMENT variable #9240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuichiro-makigaki
requested review from
niedbalski,
patrick-stephens and
celalettin1286
as code owners
|
Let's update the Windows ones too I think to be consistent - I know they're different but moving forward we should try to make changes across both. |
shuichiro-makigaki
force-pushed
the
add-option-alignment
branch
from
b5a18bf
to
2894312
Compare
patrick-stephens
approved these changes
Aug 16, 2024
shuichiro-makigaki
force-pushed
the
add-option-alignment
branch
3 times, most recently
from
644f90d
to
01e7934
Compare
Signed-off-by: Shuichiro MAKIGAKI <shuichiro.makigaki@gmail.com>
shuichiro-makigaki
force-pushed
the
add-option-alignment
branch
from
01e7934
to
8eed4ca
Compare
|
@patrick-stephens I reverted the changes of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a variable
FLB_ENFORCE_ALIGNMENTto dockerfiles following #9174.We can change memory alignment feature but keep it
Offas default. The current behavior does not change.Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.