Dont snap in pre-roll (#36173) #36181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Gold has detected about 1 new digest(s) on patchset 1. |
dnfield
approved these changes
Sep 16, 2022
|
Going to merge one more commit into this to pickup and additional case |
dnfield
approved these changes
Sep 16, 2022
|
Gold has detected about 1 new digest(s) on patchset 3. |
|
Lets not merge this, there is something not right yet |
jonahwilliams
changed the title
|
now this is updated |
|
Gold has detected about 1 new digest(s) on patchset 4. |
|
@itsjustkevin I believe this needs to be cherry-picked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't snap during pre-roll. This doesn't fix all of the issues, but does make things more consistent