[CP-stable]Fix rendering corruption by Flutter and GDK sharing the same OpenGL context #53183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontext (flutter#53103) Fix rendering corruption by Flutter and GDK sharing the same OpenGL context Solved by having three contexts - one for GDK and two for Flutter. Regression introduced in flutter#50754 Fixes flutter/flutter#148653
flutteractionsbot
added
the
cp: review
|
@robert-ancell please fill out the PR description above, afterwards the release team will review this request. |
cbracken
approved these changes
Jun 5, 2024
…7c40f2ba9150670dff301a08753401b7d
itsjustkevin
approved these changes
Jul 2, 2024
itsjustkevin
added
the
autosubmit
auto-submit
bot
merged commit a3194fa
into
flutter:flutter-3.22-candidate.0
24 checks passed
christopherfujino
added a commit
that referenced
this pull request
Jul 12, 2024
# Flutter stable 3.22.3 Engine ## Scheduled Cherrypicks - Roll dart revision: dart-lang/sdk@604651494 ### Dart - dart-lang/sdk#55979 - dart-lang/sdk#55943 ### Engine - flutter/flutter#149700 - flutter/flutter#149701 - flutter/flutter#149702 - flutter/flutter#149704 - flutter/flutter#149745 - flutter/flutter#149771 - #53183 --------- Co-authored-by: Martin Kustermann <kustermann@google.com> Co-authored-by: Jackson Gardner <eyebrowsoffire@gmail.com> Co-authored-by: Christopher Fujino <christopherfujino@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
Issue Link:
What is the link to the issue this cherry-pick is addressing?
flutter/flutter#148653
Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See best practices for examples
Linux applications showing visual corruption on some frames
Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)
Visual corruption seen on Linux Flutter apps, affects production apps.
Workaround:
Is there a workaround for this issue?
No workaround.
Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
(rendering corruption not currently testable, may not be possible to test).
Validation Steps:
What are the steps to validate that this fix works?
Run app in flutter/flutter#148653 and observe popup not rendering correctly or corruption during window resize.