Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ButtonBar, ButtonBarThemeData, and ThemeData.buttonBarTheme #144467

Closed
wants to merge 1 commit into from

Conversation

TahaTesser
Copy link
Member

fixes Deprecate ButtonBar

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. c: tech-debt Technical debt, code quality, testing, etc. labels Mar 1, 2024
@TahaTesser
Copy link
Member Author

TahaTesser commented Mar 1, 2024

This fails customer_testing for flutter/packages, uses a 6 months old commit from flutter/tests repo.

The latest flutter/packages commit no longer have ButtonBar, if customer_testing used latest flutter/packages commit this will pass.

I'm on vacation from next week so i'll refile this after i come back.

@TahaTesser TahaTesser closed this Mar 1, 2024
@TahaTesser TahaTesser mentioned this pull request Mar 1, 2024
auto-submit bot pushed a commit to flutter/tests that referenced this pull request Mar 18, 2024
Similar to #297 and #276

Unblocks flutter/flutter#144467 (comment)

This updates the 6 months old packages commit which blocks a Flutter PR as its unable to test newer versions of the packages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: tech-debt Technical debt, code quality, testing, etc. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate ButtonBar
1 participant