Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: linting and analyzer issues #533

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix: linting and analyzer issues #533

wants to merge 5 commits into from

Conversation

OutdatedGuy
Copy link
Contributor

Fixes

  • Analyzer uses deprecated options
  • Missing required trailing commas

New

  • Strictly mention data types

MarkOSullivan94
MarkOSullivan94 reviewed Dec 29, 2023
View reviewed changes
Copy link
Collaborator

@MarkOSullivan94 MarkOSullivan94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should Map<String, dynamic> not work as well as Map<dynamic, dynamic>?

Rather be more specific with our types if we can

@OutdatedGuy
Copy link
Contributor Author

Should Map<String, dynamic> not work as well as Map<dynamic, dynamic>?

Rather be more specific with our types if we can

Yeah true, my bad. I'll change it.

@OutdatedGuy OutdatedGuy force-pushed the fix/linting-issues branch 2 times, most recently from d9317e5 to 8efdef4 Compare December 29, 2023 18:23
@OutdatedGuy
Copy link
Contributor Author

Hi @MarkOSullivan94, I have made types more specific wherever possible without having an error. Please review it.

@OutdatedGuy
Copy link
Contributor Author

@MarkOSullivan94, when would this be merged. A ton of issues and PRs are pilling up for this package.

Is there anything I can help with?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkOSullivan94 MarkOSullivan94 Awaiting requested review from MarkOSullivan94

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OutdatedGuy @MarkOSullivan94