fix(template): wrong attribute to remove alpha channel #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -96,7 +96,6 @@ Shown below is the full list of attributes which you can specify within your Flu | |||
| - `true`: Override the default existing Flutter launcher icon for the platform specified | |||
| - `false`: Ignore making launcher icons for this platform | |||
| - `icon/path/here.png`: This will generate a new launcher icons for the platform with the name you specify, without removing the old default existing Flutter launcher icon. | |||
| - `image_path`: The location of the icon image file which you want to use as the app launcher icon | |||
There was a problem hiding this comment.
This is still used
Please undo this removal
There was a problem hiding this comment.
@MarkOSullivan94 I think this is a duplicate of the line that exists in the global section, this confuses me. Also, this one is not displayed in the IOS section. Is that right, or is ios missing this line? If not, I will revert the change. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the template after running the command to create a new config automatically:
remove_alpha_channel_iosattribute withremove_alpha_iosadaptive_icon_foreground_insetandbackground_color_ios