Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: getting started with branch planner #784

Merged
merged 4 commits into from
Jul 21, 2023
Merged

Conversation

yitsushi
Copy link
Collaborator

Tried to explain most of the steps, but intentionally did not add docs about how to configure the tf-controller itself and set it as a pre-requirement.

I'm not sure it satisfies #783 or not, but it's related to that issue.

Related to #783

References:

@yitsushi
Copy link
Collaborator Author

Based on this document we can add the entry with refined (more user friendly) wording to the docs website under Terraform.

docs/branch_based_planner/getting-started.md Outdated Show resolved Hide resolved
docs/branch_based_planner/getting-started.md Outdated Show resolved Hide resolved
docs/branch_based_planner/getting-started.md Outdated Show resolved Hide resolved
docs/branch_based_planner/getting-started.md Outdated Show resolved Hide resolved
docs/branch_based_planner/getting-started.md Outdated Show resolved Hide resolved
docs/branch_based_planner/getting-started.md Outdated Show resolved Hide resolved
docs/branch_based_planner/getting-started.md Outdated Show resolved Hide resolved
docs/branch_based_planner/getting-started.md Outdated Show resolved Hide resolved
docs/branch_based_planner/getting-started.md Outdated Show resolved Hide resolved
docs/branch_based_planner/getting-started.md Outdated Show resolved Hide resolved
yitsushi and others added 3 commits July 20, 2023 13:35
Tried to explain most of the steps, but intentionally did not add docs
about how to configure the tf-controller itself and set it as a
pre-requirement.

I'm not sure it satisfies #783 or not, but it's related to that issue.

Related to #783

References:
* #783

Signed-off-by: Balazs Nadasdi <balazs@weave.works>
Signed-off-by: Balazs Nadasdi <balazs@weave.works>
Co-authored-by: Lauri Apple <2453640+LappleApple@users.noreply.github.com>
Signed-off-by: Balazs Nadasdi <balazs@weave.works>
Co-authored-by: Lauri Apple <2453640+LappleApple@users.noreply.github.com>
Copy link
Contributor

@LappleApple LappleApple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yitsushi yitsushi dismissed LappleApple’s stale review July 20, 2023 11:59

all requested changes are addressed

@yitsushi yitsushi merged commit db5bc0a into main Jul 21, 2023
4 checks passed
@bigkevmcd bigkevmcd deleted the 783-getting-started-doc branch September 14, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants