Release 1.23.2

[kingdonb]

This release only changes one thing, a bug fix:

• Unable to fetch tags from ECR  #3015, closed via Skip AWS Metadata API pre-flight check when regions are passed via config #3485

Reviewer, please see also the Chart update PR in:

• Release chart 1.10.2 #3522

[kingdonb]

We can consider adding

• Add CodeQL Security Scanning #3446 and
• reset sync errors on successful sync #3156

in this release as well, but if there are issues with approving either of those straight away...

I would rather release this version from this PR as-is, because it has already been confirmed as a fix for current users who are experiencing the issue described from #3015 in the wild.

(Let's merge these two PRs in another patch release later in this series, I will open a 1.23.3 milestone if there is agreement.)

[kingdonb]

Based on the roundabout steps I had to take to attempt to triage #3523 this morning (which is probably the same issue fixed by this PR, #3485), I think this release should probably not be published without including some specific new documentation.

Perhaps adding an FAQ entry or two would make it better, about ECR and the common modes of failure we have seen, and the workarounds that are possible. The workaround is really small, but the fact that it requires a docs update and users to change their behavior in order to take advantage, suggests to me this change may be a MINOR rather than PATCH update.

Users have to know, for example, that in many common cases the Flux daemon's ECR pre-flight checks will not succeed, and they will need to provide region information manually to enable scanning of ECRs, even if they are properly permitted by IAM.

[kingdonb]

We have agreement in today's Flux Dev meeting that this is a PATCH release, as it fixes a bug.

If you specify the region, then Flux has no reason to try to reach the Instance Metadata API, and therefore it is a bug. So I now think this release should go out as-is. There is no new required reading, I will update the changelog to reflect the actual release date and get this released soon.

[kingdonb]

Approved, via #3522