Fix incorrect use of format strings with the conditions package.
#1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprodan
added
the
backport:release/v1.0.x
|
Thanks for the quick reviews @stefanprodan! 🎉 |
|
@octo please fix: |
octo
force-pushed
the
fix-conditions-usage
branch
from
f97e3dd
to
02132ec
Compare
✅ done |
The `Mark…` functions in the `conditions` package accept a format string and (optional) arguments, just like `fmt.Printf` and friends. In many places, the code passed an error message as the format string, causing it to be interpreted as a format string by the `fmt` package. This leads to issues when the message contains percent signs, e.g. URL-encoded values. This PR adds a format string and shortens `err.Error()` to `err`, which yields the same output. This change is identical in principle to fluxcd/source-controller#1529. Signed-off-by: Florian Forster <fforster@gitlab.com>
octo
force-pushed
the
fix-conditions-usage
branch
from
02132ec
to
c94eb8e
Compare
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Mark…functions in theconditionspackage accept a format string and (optional) arguments, just likefmt.Printfand friends.In many places, the code passed an error message as the format string, causing it to be interpreted as a format string by the
fmtpackage. This leads to issues when the message contains percent signs, e.g. URL-encoded values.This PR adds a format string and shortens
err.Error()toerr, which yields the same output.This change is identical in principle to fluxcd/source-controller#1529.