Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kustomize packages to Kustomize v4.4.1 #374

Merged
merged 1 commit into from
Dec 7, 2021
Merged

Update kustomize packages to Kustomize v4.4.1 #374

merged 1 commit into from
Dec 7, 2021

Conversation

mdnfiras
Copy link
Contributor

@mdnfiras mdnfiras commented Dec 7, 2021 •
edited by stefanprodan
Loading

This will update kustomize packages to a version that supports yaml anchors.

Fix: #372

@hiddeco hiddeco added the area/ci CI related issues and pull requests label Dec 7, 2021
stefanprodan
stefanprodan reviewed Dec 7, 2021
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

go: sigs.k8s.io/kustomize/api@v0.10.1: missing go.sum entry; to add it:
	go mod download sigs.k8s.io/kustomize/api

Please run make tidy and force push the changes.

Update kustomize packages
628ffb5 
Signed-off-by: Firas Medini <mdnfiras@yahoo.com>
@stefanprodan stefanprodan changed the title Update kustomize packages Update kustomize packages to Kustomize v4.4.1 Dec 7, 2021
stefanprodan
stefanprodan approved these changes Dec 7, 2021
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @mdnfiras

@stefanprodan stefanprodan merged commit 520e30d into fluxcd:main Dec 7, 2021
@mdnfiras
Copy link
Contributor Author

mdnfiras commented Dec 7, 2021

@stefanprodan thank you too sir!

@mdnfiras mdnfiras deleted the update-kustomize-packages branch December 7, 2021 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
area/ci CI related issues and pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when deploying helm chart with yaml anchors
3 participants
@mdnfiras @stefanprodan @hiddeco