Add uninstall disableWait flag #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samueltorres
force-pushed
the
add-uninstall-wait-feature
branch
from
5163b5d
to
5b07a8b
Compare
hiddeco
reviewed
Feb 15, 2022
There was a problem hiding this comment.
Thank you for this PR, looks like it is a newly added flag introduced a couple Helm releases ago which I missed. 🙇
I think the default behavior should be to wait (because that results in the best observation of an uninstall), to be inline with the other wait related flags for e.g. Install and Upgrade. The flag in the Custom Resource would then become DisableWait.
hiddeco
added
area/helm
samueltorres
force-pushed
the
add-uninstall-wait-feature
branch
3 times, most recently
from
7c0300f
to
d9cfe7e
Compare
|
Makes total sense :) Thanks for remind me that. |
samueltorres
force-pushed
the
add-uninstall-wait-feature
branch
from
d9cfe7e
to
72ccc74
Compare
This commit changes the default behavior of the Helm uninstall action to wait for all resources to be deleted, and introduces a `.spec.uninstall.disableWait` flag to disable this behavior. Signed-off-by: Samuel Torres <samuelpirestorres@gmail.com>
Signed-off-by: Hidde Beydals <hello@hidde.co>
hiddeco
force-pushed
the
add-uninstall-wait-feature
branch
from
72ccc74
to
ba35b00
Compare
stefanprodan
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a uninstall
disableWaitproperty on Helm Release Uninstall API, so users can set whether Helm Controller waits for all the resources to be deleted before finalizing the Helm Release.This is very handy to ensure Helm Releases are fully un-installed. See Slack Thread.