Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kubeconfig flags #455

Merged
merged 2 commits into from
Apr 1, 2022
Merged

Add kubeconfig flags #455

merged 2 commits into from
Apr 1, 2022

Conversation

pjbgf
Copy link
Member

@pjbgf pjbgf commented Mar 31, 2022

Two new flags were added to allow users to enable the use of user.Exec (--insecure-kubeconfig-exec) and InsecureTLS (insecure-kubeconfig-tls) in the kubeconfigs provided for remote apply.

Breaking change: both functionalities are no longer enabled by default.

Provides feature parity with kustomize: fluxcd/kustomize-controller#593

internal/kube/client.go Outdated Show resolved Hide resolved
Paulo Gomes added 2 commits March 31, 2022 14:51
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
Two new flags were added to allow users to enable the
use of user.Exec and InsecureTLS in the kubeconfigs
provided remote apply reconciliations.

Breaking change: both functionalities are no longer
enabled by default.

Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
@pjbgf pjbgf added this to the GA milestone Mar 31, 2022
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @pjbgf

PS. We need to document this in the Security section of our docs.

@stefanprodan stefanprodan merged commit 7799036 into fluxcd:main Apr 1, 2022
@pjbgf pjbgf deleted the new-kube-flag branch April 1, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants