kube: unify clients into single RESTClientGetter #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
force-pushed
the
kube-improvements
branch
4 times, most recently
from
fc281bf
to
247ba12
Compare
This drops the twofold implementation in favor of a single `MemoryRESTClientGetter` which can work with an arbitrary `rest.Config`. The new `MemoryRESTClientGetter` lazy-loads and caches the objects it initializes, thereby creating at most one instance of each object for the duration of the reconcile of a single `HelmRelease` object. Based on some initial tests, this seems to reduce the overal memory footprint of the controller. Signed-off-by: Hidde Beydals <hidde@hhh.computer>
hiddeco
force-pushed
the
kube-improvements
branch
from
247ba12
to
34d87cc
Compare
As otherwise with a persistent discovery client and/or REST mapper configuration, newly installed CRDs will not be recognized and cause a `resource mapping not found for name` error. In addition, remove the `ServerGroups` and `Invalidate` calls. As this is later done (again) by Helm when gathering server capabilities. Signed-off-by: Hidde Beydals <hidde@hhh.computer>
hiddeco
force-pushed
the
kube-improvements
branch
from
11aeaf1
to
b68592c
Compare
hiddeco
added
enhancement
hiddeco
requested review from
stefanprodan and
pjbgf
and removed request for
stefanprodan
pjbgf
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops the twofold implementation in favor of a single
MemoryRESTClientGetterwhich can work with an arbitraryrest.Config.The new
MemoryRESTClientGetterlazy-loads and caches the objects itinitializes, thereby creating at most one instance of each object for
the duration of the reconcile of a single
HelmReleaseobject.Based on some initial tests, this seems to reduce the overal memory
footprint of the controller.
🚀 Release candidate:
ghcr.io/fluxcd/helm-controller:rc-b68592c4Memory usage before
Memory usage after