Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move controllers to internal/controllers #653

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Move controllers to internal/controllers #653

merged 1 commit into from
Mar 27, 2023

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Mar 27, 2023 •
edited by stefanprodan
Loading

@hiddeco hiddeco marked this pull request as ready for review March 27, 2023 14:54
@hiddeco
Move controllers to internal/controllers
3615fee 
There is no good reason for it to be exposed and available through a
public API, and this follows the new kubebuilder defaults.

Signed-off-by: Hidde Beydals <hidde@hhh.computer>
@hiddeco hiddeco added the area/ci CI related issues and pull requests label Mar 27, 2023
@hiddeco hiddeco merged commit 0d47c9c into main Mar 27, 2023
@hiddeco hiddeco deleted the internal-controllers branch March 27, 2023 15:36
@joejulian joejulian mentioned this pull request Jun 12, 2023
Closed
@joejulian joejulian mentioned this pull request Sep 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
area/ci CI related issues and pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiddeco @stefanprodan