Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loader: log HTTP errors to provide faster feedback #845

Merged
merged 1 commit into from
Dec 13, 2023
Merged

loader: log HTTP errors to provide faster feedback #845

merged 1 commit into from
Dec 13, 2023

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Dec 13, 2023 •
edited by stefanprodan
Loading

@hiddeco hiddeco force-pushed the retry-http-log-errors branch 3 times, most recently from 4475b0b to 6930ecd Compare December 13, 2023 09:52
stefanprodan
stefanprodan approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @hiddeco

@stefanprodan stefanprodan added the area/ux In pursuit of a delightful user experience label Dec 13, 2023
@hiddeco hiddeco marked this pull request as ready for review December 13, 2023 10:00
@hiddeco
loader: log HTTP errors to provide faster feedback
07e2046 
This configures a logger on the HTTP client used to load a Helm chart,
ensuring HTTP errors surface faster.

Signed-off-by: Hidde Beydals <hidde@hhh.computer>
@hiddeco hiddeco merged commit bafafe2 into main Dec 13, 2023
6 checks passed
@hiddeco hiddeco deleted the retry-http-log-errors branch December 13, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
area/ux In pursuit of a delightful user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiddeco @stefanprodan