Add support for HelmChart as chartRef
#945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If implemented, user will be able to share an existing HelmChart custom resource between HelmReleases. Signed-off-by: Soule BA <bah.soule@gmail.com>
souleb
force-pushed
the
enable-hc-sources
branch
from
98ab150
to
3bb715a
Compare
Signed-off-by: Soule BA <bah.soule@gmail.com>
|
switching from chart template to Status:
Conditions:
Last Transition Time: 2024-04-22T09:39:21Z
Message: Helm upgrade succeeded for release default/podinfo-template.v2 with chart podinfo@0.1.0
Observed Generation: 3
Reason: UpgradeSucceeded
Status: True
Type: Ready
Last Transition Time: 2024-04-18T09:13:16Z
Message: Helm upgrade succeeded for release default/podinfo-template.v2 with chart podinfo@0.1.0
Observed Generation: 2
Reason: UpgradeSucceeded
Status: True
Type: Released
History:
Chart Name: podinfo
Chart Version: 0.1.0
Config Digest: sha256:e15c415d62760896bd8bec192a44c5716dc224db9e0fc609b9ac14718f8f9e56
Digest: sha256:60770b7d040612283cc8931f8b67fd34d446d3b5316949e7a8803de05b448599
First Deployed: 2024-04-16T08:28:52Z
Last Deployed: 2024-04-18T09:13:12Z
Name: podinfo-template
Namespace: default
Status: deployed
Version: 2
Chart Name: podinfo
Chart Version: 6.0.4
Config Digest: sha256:e15c415d62760896bd8bec192a44c5716dc224db9e0fc609b9ac14718f8f9e56
Digest: sha256:912442ff9c2798eec85cdd81cc5dc5bab63d952fefbf423b32d52dda5cfb426a
First Deployed: 2024-04-16T08:28:52Z
Last Deployed: 2024-04-16T08:28:52Z
Name: podinfo-template
Namespace: default
Status: superseded
Version: 1
Last Applied Revision: 0.1.0
Last Attempted Config Digest: sha256:e15c415d62760896bd8bec192a44c5716dc224db9e0fc609b9ac14718f8f9e56
Last Attempted Generation: 3
Last Attempted Release Action: upgrade
Last Attempted Revision: 0.1.0
Observed Generation: 3
Storage Namespace: default
Events:
Type Reason Age From Message
---- ------ ---- ---- -------
Normal HelmChartDeleted 23s helm-controller deleted HelmChart 'default/default-podinfo-template'It successfully garbage collect the old |
stefanprodan
changed the title
HelmChart as chartRef
Co-authored-by: Stefan Prodan <stefan.prodan@gmail.com> Signed-off-by: souleb <bah.soule@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If implemented, user will be able to share an existing HelmChart custom resource between HelmReleases.
Closes: #204
Followup: #905