Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update agent endpoint in the single binary #3779

Merged
merged 5 commits into from
Jun 13, 2023
Merged

Update agent endpoint in the single binary #3779

merged 5 commits into from
Jun 13, 2023

Conversation

pingsutw
Copy link
Member

Tracking issue

Describe your changes

update endpoint. flyte-sandbox-http -> flyte-binary-http

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Screenshots

Note to reviewers

Signed-off-by: Kevin Su <pingsutw@apache.org>
@eapolinario
Copy link
Contributor

We should keep an override in the case of sandbox. More specifically, we need to add something like https://github.com/flyteorg/flyte/blob/master/charts/flyte-binary/values.yaml#L151-L154 to the sandbox values.yaml file.

Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
@eapolinario eapolinario merged commit 1ae254f into master Jun 13, 2023
@eapolinario eapolinario deleted the update-svc branch June 13, 2023 20:32
@pingsutw pingsutw mentioned this pull request Aug 9, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants