Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Deploying agents in the sandbox #5107

Closed
wants to merge 4 commits into from

Conversation

Future-Outlier
Copy link
Member

@Future-Outlier Future-Outlier commented Mar 26, 2024

Docs link

index: https://flyte--5107.org.readthedocs.build/en/5107/flyte_agents/index.html
content: https://flyte--5107.org.readthedocs.build/en/5107/flyte_agents/deploying_agents_to_the_flyte_sandbox.html

Tracking issue

#3936

Why are the changes needed?

Help users to develop agents more easily.

What changes were proposed in this pull request?

Setup process

Screenshots

image image

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Signed-off-by: Future-Outlier <eric901201@gmail.com>
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. documentation Improvements or additions to documentation labels Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.03%. Comparing base (d68047a) to head (1289856).
Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5107      +/-   ##
==========================================
+ Coverage   58.56%   59.03%   +0.46%     
==========================================
  Files         494      645     +151     
  Lines       42987    55726   +12739     
==========================================
+ Hits        25176    32896    +7720     
- Misses      15816    20233    +4417     
- Partials     1995     2597     +602     
Flag Coverage Δ
unittests 59.03% <ø> (+0.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Future-Outlier
Copy link
Member Author

cc @neverett
Do you know how to make the CI pass the test?
I'm not really sure about how to make it pass the test.
Thank you!

Signed-off-by: Future-Outlier <eric901201@gmail.com>
Signed-off-by: Future-Outlier <eric901201@gmail.com>
@Future-Outlier
Copy link
Member Author

cc @neverett Do you know how to make the CI pass the test? I'm not really sure about how to make it pass the test. Thank you!

CI works now, please review, thanks a lot.
I'm not sure the way I embed the image here is right or not.

Signed-off-by: Kevin Su <pingsutw@gmail.com>
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Mar 28, 2024
@Future-Outlier Future-Outlier marked this pull request as draft April 2, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants