Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flyteagent] Remove redundant code in Agent #5454

Merged
merged 4 commits into from
Jun 14, 2024

Conversation

Future-Outlier
Copy link
Member

@Future-Outlier Future-Outlier commented Jun 7, 2024

Tracking issue

#3936

Why are the changes needed?

Comment in the description below.

What changes were proposed in this pull request?

How was this patch tested?

single binary.

Setup process

Screenshots

image

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Signed-off-by: Future-Outlier <eric901201@gmail.com>
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 61.01%. Comparing base (25c3596) to head (fce16bf).
Report is 142 commits behind head on master.

Files with missing lines Patch % Lines
...yteplugins/go/tasks/plugins/webapi/agent/client.go 50.00% 1 Missing and 1 partial ⚠️
...yteplugins/go/tasks/plugins/webapi/agent/plugin.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5454      +/-   ##
==========================================
- Coverage   61.07%   61.01%   -0.07%     
==========================================
  Files         793      793              
  Lines       51226    51289      +63     
==========================================
+ Hits        31288    31292       +4     
- Misses      17062    17119      +57     
- Partials     2876     2878       +2     
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.66% <ø> (-0.25%) ⬇️
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 67.97% <ø> (ø)
unittests-flyteidl 79.04% <ø> (ø)
unittests-flyteplugins 61.97% <33.33%> (+0.02%) ⬆️
unittests-flytepropeller 57.32% <ø> (ø)
unittests-flytestdlib 65.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Future-Outlier <eric901201@gmail.com>
Co-authored-by: pingsutw  <pingsutw@apache.org>
@Future-Outlier Future-Outlier enabled auto-merge (squash) June 8, 2024 03:30
@Future-Outlier Future-Outlier merged commit bba8c11 into master Jun 14, 2024
48 of 50 checks passed
@Future-Outlier Future-Outlier deleted the agent-plugin-refactor branch June 14, 2024 04:01
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this pull request Jul 2, 2024
* Remove Redundant code in Agent

Signed-off-by: Future-Outlier <eric901201@gmail.com>

* improve error messages

Signed-off-by: Future-Outlier <eric901201@gmail.com>

* change  to

Signed-off-by: Future-Outlier <eric901201@gmail.com>

* Remove defer func() by pingsu's advice.

Signed-off-by: Future-Outlier <eric901201@gmail.com>
Co-authored-by: pingsutw  <pingsutw@apache.org>

---------

Signed-off-by: Future-Outlier <eric901201@gmail.com>
Co-authored-by: pingsutw <pingsutw@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants