Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flyteagent] Enable agent-service in every configuration #5730

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

Future-Outlier
Copy link
Member

@Future-Outlier Future-Outlier commented Sep 8, 2024

Tracking issue

#3936

Why are the changes needed?

I found that gke-starter.yaml doesn't enable agent-service in it's helm chart, since agent watcher is merged and well-tested, we can enable agent-service whether agent is deployed or not.

What changes were proposed in this pull request?

add agent-service in every config that has enabled-plugins section.

How was this patch tested?

cd docker/sandbox-bundled
make build
flytectl demo start --force --disable-agent --image flyte-sandbox:latest
image

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

I will update the documentation in the follow-up PR.

Signed-off-by: Future-Outlier <eric901201@gmail.com>
Copy link

codecov bot commented Sep 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.21%. Comparing base (a058fd1) to head (964d333).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5730      +/-   ##
==========================================
- Coverage   36.21%   36.21%   -0.01%     
==========================================
  Files        1303     1303              
  Lines      109560   109560              
==========================================
- Hits        39675    39674       -1     
- Misses      65765    65766       +1     
  Partials     4120     4120              
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (ø)
unittests-flyteadmin 55.63% <ø> (ø)
unittests-flytecopilot 12.17% <ø> (ø)
unittests-flytectl 62.17% <ø> (ø)
unittests-flyteidl 7.12% <ø> (ø)
unittests-flyteplugins 53.35% <ø> (ø)
unittests-flytepropeller 41.76% <ø> (ø)
unittests-flytestdlib 55.33% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Future-Outlier Future-Outlier enabled auto-merge (squash) September 8, 2024 03:34
@Future-Outlier Future-Outlier changed the title Enable agent-service in every helm chart [flyteagent] Enable agent-service in every helm chart Sep 8, 2024
@Future-Outlier Future-Outlier changed the title [flyteagent] Enable agent-service in every helm chart [flyteagent] Enable agent-service in every configuration Sep 8, 2024
@Future-Outlier Future-Outlier merged commit f7ce7eb into master Sep 8, 2024
55 checks passed
@Future-Outlier Future-Outlier deleted the enable-agent-service-in-every-yaml branch September 8, 2024 06:32
bgedik pushed a commit to bgedik/flyte that referenced this pull request Sep 12, 2024
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Signed-off-by: Bugra Gedik <bgedik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants