Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the flytectl config.yaml admin.clientSecretEnvVar option in flytekit #1819

refactor variable name.

25e624a
Select commit
Loading
Failed to load commit list.
Merged

Support the flytectl config.yaml admin.clientSecretEnvVar option in flytekit #1819

refactor variable name.
25e624a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Sep 6, 2023 in 0s

18.72% (-0.01%) compared to f6cfc9d

View this Pull Request on Codecov

18.72% (-0.01%) compared to f6cfc9d

Details

Codecov Report

Patch coverage: 16.66% and project coverage change: -0.01% ⚠️

Comparison is base (f6cfc9d) 18.72% compared to head (25e624a) 18.72%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1819      +/-   ##
==========================================
- Coverage   18.72%   18.72%   -0.01%     
==========================================
  Files         332      332              
  Lines       31352    31386      +34     
  Branches     3078     3083       +5     
==========================================
+ Hits         5871     5876       +5     
- Misses      25399    25426      +27     
- Partials       82       84       +2     
Files Changed Coverage Δ
tests/flytekit/unit/configuration/test_internal.py 0.00% <0.00%> (ø)
flytekit/configuration/__init__.py 71.51% <21.42%> (-1.53%) ⬇️
flytekit/configuration/internal.py 80.51% <100.00%> (+0.51%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.