Improvement: accept int value for Resources #2196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowc1012
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
dosubot
bot
added
the
size:XS
lowc1012
force-pushed
the
flyteki-issue-4691
branch
from
f3f0c0a
to
42159b5
Compare
dosubot
bot
added
size:M
lowc1012
force-pushed
the
flyteki-issue-4691
branch
from
f210f77
to
7b03b8d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2196 +/- ##
==========================================
- Coverage 83.04% 80.59% -2.45%
==========================================
Files 324 180 -144
Lines 24861 17856 -7005
Branches 3547 3483 -64
==========================================
- Hits 20645 14391 -6254
+ Misses 3591 2843 -748
+ Partials 625 622 -3 ☔ View full report in Codecov by Sentry. |
pingsutw
reviewed
Feb 17, 2024
Signed-off-by: Ryan Lo <wenchih@apache.org>
lowc1012
force-pushed
the
flyteki-issue-4691
branch
from
d974e01
to
e535b34
Compare
Signed-off-by: Ryan Lo <wenchih@apache.org>
lowc1012
force-pushed
the
flyteki-issue-4691
branch
from
ea42aca
to
fa90d9c
Compare
Signed-off-by: Ryan Lo <wenchih@apache.org>
lowc1012
force-pushed
the
flyteki-issue-4691
branch
from
861ccf1
to
3853409
Compare
3 tasks
Signed-off-by: Ryan Lo <wenchih@apache.org>
|
Can you merge master ? |
pingsutw
approved these changes
Apr 30, 2024
|
Congrats on merging your first pull request! 🎉 |
austin362667
pushed a commit
to austin362667/flytekit
that referenced
this pull request
May 9, 2024
Signed-off-by: Ryan Lo <wenchih@apache.org> Co-authored-by: Kevin Su <pingsutw@gmail.com>
austin362667
pushed a commit
to austin362667/flytekit
that referenced
this pull request
May 10, 2024
Signed-off-by: Ryan Lo <wenchih@apache.org> Co-authored-by: Kevin Su <pingsutw@gmail.com>
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
Signed-off-by: Ryan Lo <wenchih@apache.org> Co-authored-by: Kevin Su <pingsutw@gmail.com> Signed-off-by: Jan Fiedler <jan@union.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes flyteorg/flyte #4691
Why are the changes needed?
Make str and int available for mem, gpu and ephemeral_storage.
Make str, int, float available for cpu.
What changes were proposed in this pull request?
Update Resources class in flytekit/core/resources.py
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link