[bitnami/memcached] Allow disabling enableServiceLinks (bitnami#25898)

Signed-off-by: Ben Foster <bpfoster@gmail.com> Signed-off-by: Fran Mulero <fmulero@vmware.com> Co-authored-by: Fran Mulero <fmulero@vmware.com> Signed-off-by: Fran Mulero <fmulero@vmware.com>
fmulero · May 22, 2024 · 1b503dd · 1b503dd
1 parent c824f9f
commit 1b503dd
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 1 deletion.
diff --git a/bitnami/memcached/Chart.yaml b/bitnami/memcached/Chart.yaml
@@ -31,4 +31,4 @@ maintainers:
 name: memcached
 sources:
 - https://github.com/bitnami/charts/tree/main/bitnami/memcached
-version: 7.2.0
+version: 7.3.0
diff --git a/bitnami/memcached/README.md b/bitnami/memcached/README.md
@@ -226,6 +226,7 @@ If you encounter errors when working with persistent volumes, refer to our [trou
 | `extraVolumeMounts`                                 | Optionally specify extra list of additional volumeMounts for the Memcached container(s)                                                                                                                           | `[]`             |
 | `sidecars`                                          | Add additional sidecar containers to the Memcached pod(s)                                                                                                                                                         | `[]`             |
 | `initContainers`                                    | Add additional init containers to the Memcached pod(s)                                                                                                                                                            | `[]`             |
+| `enableServiceLinks`                                | Whether information about services should be injected into pod's environment variable                                                                                                                             | `true`           |
 | `autoscaling.enabled`                               | Enable memcached statefulset autoscaling (requires architecture: "high-availability")                                                                                                                             | `false`          |
 | `autoscaling.minReplicas`                           | memcached statefulset autoscaling minimum number of replicas                                                                                                                                                      | `3`              |
 | `autoscaling.maxReplicas`                           | memcached statefulset autoscaling maximum number of replicas                                                                                                                                                      | `6`              |

diff --git a/bitnami/memcached/templates/deployment.yaml b/bitnami/memcached/templates/deployment.yaml
@@ -70,6 +70,7 @@ spec:
       terminationGracePeriodSeconds: {{ .Values.terminationGracePeriodSeconds }}
       {{- end }}
       serviceAccountName: {{ template "memcached.serviceAccountName" . }}
+      enableServiceLinks: {{ .Values.enableServiceLinks }}
       {{- if .Values.initContainers }}
       initContainers: {{- include "common.tplvalues.render" (dict "value" .Values.initContainers "context" $) | nindent 8 }}
       {{- end }}

diff --git a/bitnami/memcached/templates/statefulset.yaml b/bitnami/memcached/templates/statefulset.yaml
@@ -76,6 +76,7 @@ spec:
       terminationGracePeriodSeconds: {{ .Values.terminationGracePeriodSeconds }}
       {{- end }}
       serviceAccountName: {{ template "memcached.serviceAccountName" . }}
+      enableServiceLinks: {{ .Values.enableServiceLinks }}
       {{- if or .Values.persistence.enabled .Values.initContainers }}
       initContainers:
         {{- if and .Values.persistence.enabled .Values.volumePermissions.enabled }}

diff --git a/bitnami/memcached/values.yaml b/bitnami/memcached/values.yaml
@@ -393,6 +393,11 @@ sidecars: []
 ##         containerPort: 1234
 ##
 initContainers: []
+## @param enableServiceLinks Whether information about services should be injected into pod's environment variable
+## The environment variables injected by service links are not used, but can lead to slow boot times or slow running of the scripts when there are many services in the current namespace.
+## If you experience slow pod startups or slow running of the scripts you probably want to set this to `false`.
+##
+enableServiceLinks: true
 ## Memcached Autoscaling
 ## @param autoscaling.enabled Enable memcached statefulset autoscaling (requires architecture: "high-availability")
 ## @param autoscaling.minReplicas memcached statefulset autoscaling minimum number of replicas