Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Installation] Installation breaks using Node >= 15 #1859

Closed
DyeffersonAz opened this issue Jan 27, 2021 · 17 comments
Closed

[Installation] Installation breaks using Node >= 15 #1859

DyeffersonAz opened this issue Jan 27, 2021 · 17 comments
Labels
type/bug Any issue which is a bug or PR which fixes a bug type/upstream Any issues in dependencies
Milestone

Comments

@DyeffersonAz
Copy link

DyeffersonAz commented Jan 27, 2021

Bug Report

I can't install it.

Steps to reproduce

Look at the GIF (versions included):
Peek 27-01-2021 10-21

Log attached.
2021-01-27T13_20_17_699Z-debug.log

@DyeffersonAz DyeffersonAz added state/awaiting-investigation Anything which needs more investigation state/awaiting-triage Any issues or pull requests which haven't yet been triaged type/bug Any issue which is a bug or PR which fixes a bug labels Jan 27, 2021
@lubber-de
Copy link
Member

🤔 Could you try to run it using Node 12/13 ?

@lubber-de lubber-de removed the state/awaiting-triage Any issues or pull requests which haven't yet been triaged label Jan 27, 2021
@Neo-Desktop
Copy link

I also have this issue with installing
I have the following, similar setup as @DyeffersonAz, just running on windows

>node --version
v15.7.0

>npm --version
7.4.3

>gulp --version
CLI version: 2.3.0
Local version: 4.0.2

It errors out in exactly the same way

2021-01-28T11_10_35_678Z-debug.log

@lubber-de
Copy link
Member

@Neo-Desktop Again the question: Could you please try using Node 12/13 ?

@ko2in
Copy link
Member

ko2in commented Jan 29, 2021

As far as I tested, it doesn't work with node version 15.0.0 and above. All prior versions (12, 13, 14) work.

fui-npm

@DyeffersonAz
Copy link
Author

DyeffersonAz commented Jan 29, 2021

@Neo-Desktop Again the question: Could you please try using Node 12/13 ?

As @ko2in tested, nope. Same here

@lubber-de
Copy link
Member

ok, but then it's a node 15 issue "only" . Current LTS of node is 14 which works, so we have to figure out what changed in node 15. Until then only node <= 14 is officially supported

@lubber-de lubber-de added the tag/help-wanted Issues which need help to fix or implement label Jan 29, 2021
@lubber-de lubber-de changed the title [Installation] Can't complete installing, setup doesn't open [Installation] Installation breaks using Node >= 15 Jan 29, 2021
@lubber-de lubber-de added the type/upstream Any issues in dependencies label Feb 22, 2021
@jeffrson
Copy link

jeffrson commented Apr 12, 2021

I bet this is not related to Node 15, but npm7. And npm7 is official.

The interactive install breaks on all current package managers (yarn, yarn2, npm7, pnpm).

See #1767

@lubber-de lubber-de added the Hacktoberfest Issues for Hacktoberfest! label Sep 15, 2021
@lubber-de
Copy link
Member

Closing, because i cannot reproduce this anymore using the latest LTS node versions node 12/14/16 and npm 6/8)
We changed our CI script to also test for Node 16 now which works

@lubber-de lubber-de removed Hacktoberfest Issues for Hacktoberfest! state/awaiting-investigation Anything which needs more investigation tag/help-wanted Issues which need help to fix or implement labels Jan 20, 2022
@jeffrson
Copy link

Very strange.
with npm 8.3.1 > npm i --save-dev fomantic-ui

[09:09:59] Starting 'run setup'...
npm ERR! ? Set-up Semantic UI (Use arrow keys)
npm ERR! ❯ Automatic (Use default locations and all components)
npm ERR!   Express (Set components and output folder)
npm ERR!   Custom (Customize all src/dist values) [09:09:59] The following tasks did not complete: install, run setup
npm ERR! [09:09:59] Did you forget to signal async completion?

npm ERR! A complete log of this run can be found in:
...

Same output (apart from "npm ERR!") with yarn 1.22.17. yarn3 simply puts

➤ YN0007: │ fomantic-ui@npm:2.8.8 must be built because it never has been before or the last one failed
➤ YN0009: │ fomantic-ui@npm:2.8.8 couldn't be built successfully (exit code 1, logs can be found here: /tmp/xfs-14304c61/build.log)
➤ YN0000: └ Completed in 4s 641ms
➤ YN0000: Failed with errors in 9s 988ms

Haven#t tried pnpm. But I guess it still works with npm6 only. So nothing changed at all :-(

@lubber-de
Copy link
Member

🙄 Ok, i reopen again

@lubber-de lubber-de reopened this Jan 21, 2022
@lubber-de lubber-de added state/awaiting-investigation Anything which needs more investigation tag/help-wanted Issues which need help to fix or implement labels Jan 21, 2022
@lubber-de
Copy link
Member

lubber-de commented Jan 24, 2022

I still cannot reproduce on node 15 and npm 7. It works for me without the "NPM ERR"
image

I can confirm yarn install does not work, however yarn gulp install or yarn gulp build works as expected (afterwards) so yarn install does not start the npm install scripts.

More investigation needed. Help is appreciated. I'll try WSL ubuntu

@lubber-de
Copy link
Member

lubber-de commented Jan 24, 2022

I think this is a general issue using inquirer in postinstall. At least when using yarn.
i found this issue

which describes the same situation but not using SUI/FUI

I updated inquirer to latest 8.2.0 by #2209 (should be included in tonights nightly build) which may have fixed it at least when using npm (that's perhaps the reason, why i cannot reproduce using npm on my machine). You may try again using npm tomorrow using the nightly npm build.

As said, when using yarn gulp install or yarn gulp build manually, it works, just not while doing automatic post install.

So i suggest to install via

yarn 1.22

yarn install --ignore-scripts
yarn gulp install
yarn gulp build

yarn 2.4

yarn install --mode skip-build
yarn gulp install
yarn gulp build

@DifficultNick
Copy link

I'm sorry for repeated question, but is there any known way to use fomantic-ui for React now with node v16 and npm v8?

I got the same error as described above.

I tried steps from comment in 1911 and got 'semantic' folder in my repo as supposed, but I'm not sure if I understand what to do with it.

P.S. I fell in love with your library at first sight, but still can't install it properly =(

@lubber-de
Copy link
Member

I am sorry, I still cannot reproduce, please somebody else step in.
npm install fomantic-ui --ignore-scripts and npx gulp build works for me using node 12/14/16 and npm 6/7/8

React only needs the CSS, so if you only need the default theme, you might just install the precompiled version from https://github.com/fomantic/Fomantic-UI-CSS or https://github.com/fomantic/Fomantic-UI-LESS if you already have a LESS build somewhere in your project.

The only difference for 2.8.8 is LESS 4 and gulp-less 5 (which HAS to be used, otherwise it won't work with LESS 4.
Our nightly build uses node16/npm7

@DifficultNick
Copy link

Thanks for your answer!
Yeah, ignore-scripts + gulp install/build works. And now i realised why i was confused: I missed the thing that FUI (compared to SUI) doesn't have type definitions, so i thought it was incomplete result of compilation.

So let me ask you for advice (though it's not about this issue): if I want type definitions (because i use TS, not JS) should i use SUI and hope that FUI still will be merged back into it?

@lubber-de
Copy link
Member

if I want type definitions

You can still use the type definitions for SUI, however those won't cover the new features of FUI. If anybody volunteers to support/create/maintain type definitions for FUI, let us know!

should i use SUI and hope that FUI still will be merged back into it?

Since quite some time, i believe, this hope will not be fullfilled....

@lubber-de
Copy link
Member

Should now be fixed in #2272 because that wont start the interactive script automatically anymore

@lubber-de lubber-de added state/has-pr An issue which has a related PR open and removed tag/help-wanted Issues which need help to fix or implement state/awaiting-investigation Anything which needs more investigation labels Mar 20, 2022
@lubber-de lubber-de added this to the 2.9.0 milestone Mar 20, 2022
@lubber-de lubber-de added tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build and removed state/has-pr An issue which has a related PR open labels Mar 24, 2022
@lubber-de lubber-de removed the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Any issue which is a bug or PR which fixes a bug type/upstream Any issues in dependencies
Projects
None yet
Development

No branches or pull requests

6 participants