fix(install): dont start interactive script on npm install #2272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubber-de
added
type/build
This was referenced Mar 20, 2022
lubber-de
added
state/awaiting-docs
lubber-de
changed the title
|
Docs added by fomantic/Fomantic-UI-Docs#341 |
lubber-de
added
state/has-docs
lubber-de
added a commit
to fomantic/Fomantic-UI-Docs
that referenced
this pull request
Apr 17, 2022
Adjusted the install infos because the automatic script call on npm install has been removed as of fomantic/Fomantic-UI#2272
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the interactive auto install which was called automatically after
npm install.Whenever Fomantic UI is installed via
npm install fomantic-uithedistfolder is already available, so there is no need to compile it at install time.The main reason to remove it is that especially yarn and recent versions of npm do not work with inquirer interactive scripts as post install and throw an error.
Manually calling
npx/yarn gulp installornpx/yarn gulp buildright afternpm installhowever, works finea
--ignore-scriptsshouldn't be needed anymore thenCloses
#811
#1767
#1859
#1911
#2461