Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yasna 0.5 and related dependencies upgrade and fmt-debug fix #363

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

mridul-manohar
Copy link

@mridul-manohar mridul-manohar commented Jul 4, 2024

The currently used version of yasna is ver0.3, and it is advised to upgrade to latest yasna ver0.5.2.
This PR upgrades yasna version along with required dependencies.

Copy link

github-actions bot commented Jul 4, 2024

Benchmark for 02a9b9d

Click to view benchmark
Test Base PR %
Cipher/AES CBC decrypt 292.6±13.80ns 288.8±10.65ns -1.30%
Cipher/AES CBC encrypt 223.6±13.37ns 222.0±13.07ns -0.72%
Cipher/AES CCM decrypt 411.2±28.63ns 415.5±20.40ns +1.05%
Cipher/AES CCM encrypt 383.0±16.21ns 387.4±23.13ns +1.15%
Cipher/AES GCM decrypt 576.2±17.73ns 563.0±20.59ns -2.29%
Cipher/AES GCM encrypt 563.0±27.66ns 552.6±19.98ns -1.85%
Cipher/AES KW decrypt 699.0±28.07ns 697.9±27.19ns -0.16%
Cipher/AES KW encrypt 650.9±16.76ns 644.5±15.64ns -0.98%
Cipher/AES KWP decrypt 710.4±39.56ns 717.2±58.96ns +0.96%
Cipher/AES KWP encrypt 646.2±14.79ns 652.4±38.22ns +0.96%

@Taowyoo
Copy link
Collaborator

Taowyoo commented Aug 28, 2024

The failed CI https://github.com/fortanix/rust-mbedtls/actions/runs/10575662217/job/29380924160?pr=363 indicates there is some changes in GitHub Action's MacOS Runner.
A separate PR need to be created to fix this.

@Taowyoo Taowyoo mentioned this pull request Aug 28, 2024
@Taowyoo Taowyoo force-pushed the mridul/yasna-0.5-crate-update branch from d0a403e to 55a699f Compare August 28, 2024 23:51
…ust-mbedtls into mridul/yasna-0.5-crate-update

# Conflicts:
#	Cargo.lock
#	mbedtls-platform-support/Cargo.toml
#	mbedtls/src/x509/mod.rs
Copy link

Benchmark for 415e457

Click to view benchmark
Test Base PR %
Cipher/AES CBC decrypt 296.3±11.49ns 300.0±10.65ns +1.25%
Cipher/AES CBC encrypt 220.5±6.24ns 223.0±7.70ns +1.13%
Cipher/AES CCM decrypt 395.1±14.36ns 412.5±17.16ns +4.40%
Cipher/AES CCM encrypt 393.1±17.18ns 412.6±22.01ns +4.96%
Cipher/AES GCM decrypt 567.4±24.84ns 584.1±25.66ns +2.94%
Cipher/AES GCM encrypt 575.3±19.47ns 555.2±25.68ns -3.49%
Cipher/AES KW decrypt 705.7±20.97ns 714.8±34.65ns +1.29%
Cipher/AES KW encrypt 643.7±13.83ns 666.7±19.56ns +3.57%
Cipher/AES KWP decrypt 720.6±67.53ns 741.2±30.55ns +2.86%
Cipher/AES KWP encrypt 655.3±14.34ns 669.6±18.92ns +2.18%


mbedtls-sys-auto = { path = "../mbedtls-sys", version = "2.25.0", default-features = false, features = [
mbedtls-sys-auto = { path = "../mbedtls-sys", version = "2", default-features = false, features = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
mbedtls-sys-auto = { path = "../mbedtls-sys", version = "2", default-features = false, features = [
mbedtls-sys-auto = { path = "../mbedtls-sys", version = "2.28", default-features = false, features = [

rand = "0.4.0"
serde_cbor = "0.6"
hex = "0.3"
matches = "0.1.8"
hyper = { version = "0.10.16", default-features = false }
hyper = { version = "0.14", default-features = false }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
hyper = { version = "0.14", default-features = false }
hyper = { version = "0.10.16", default-features = false }

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't upgrade this otherwise you need to update all test code to sync up with new API in hyper

Copy link

Benchmark for 34943be

Click to view benchmark
Test Base PR %
Cipher/AES CBC decrypt 294.5±7.80ns 289.5±12.60ns -1.70%
Cipher/AES CBC encrypt 222.7±7.81ns 221.2±6.20ns -0.67%
Cipher/AES CCM decrypt 407.8±14.12ns 404.6±16.45ns -0.78%
Cipher/AES CCM encrypt 393.8±8.82ns 393.7±33.45ns -0.03%
Cipher/AES GCM decrypt 582.4±19.79ns 592.3±26.47ns +1.70%
Cipher/AES GCM encrypt 576.5±16.92ns 568.0±28.12ns -1.47%
Cipher/AES KW decrypt 712.5±19.93ns 720.6±33.81ns +1.14%
Cipher/AES KW encrypt 644.0±14.06ns 652.5±18.40ns +1.32%
Cipher/AES KWP decrypt 732.5±12.80ns 738.2±9.90ns +0.78%
Cipher/AES KWP encrypt 656.1±14.11ns 656.0±22.42ns -0.02%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants