-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can we please shut down fossasia-bot? #376
Comments
Yep, I agree with you @cclauss |
@cclauss the bot was meant as an experiment. I do agree it is a pretty chatty right now. But somethings like setting labels (needs review and ready to ship) is actually useful for big projects. And the reason the bot comments the information already provide by GH is that many contributors fail to see the status updates provided by travis. But when the bot comments by mentioning their username, they get a notification and actually see the issue. Leading to a faster response from the PR creator. Another useful function of the bot is moving issues from one repo to the other. Which is pretty damn useful in multi-repo projects. But I do agree the bot is chatty. That could be fixed. Feel free to make a PR to https://github.com/niranjan94/github-automaton . Once the PR is merged, the bot should auto-update. |
It is a bummer that GitHub web UI does not allow contributors to set a few labels like needs review. I think that humans can make that decision better than bots can. I have written to GitHub on this topic several times but no positive response yet. I do not see the value in adding the ready to ship label given that the status of the PR always changes at the same time. Moving issues from one repo to another sounds cool but does not apply here.
I think we are reinforcing bad habits (ignoring test tools) and at the same time focusing on optimizing the wrong step in our process. Our current issue is not that we are being too slow at creating PRs but that we are too slow at reviewing and merging PRs. If I am reviewing PRs and I open #343 it is really difficult for me to evaluate if this PR is ready or not because there are 14 @fossasia-bot comments that clutter the PR log that are hiding the 5 comments made by humans. fossasia-bot may have utility in other projects but here I believe that it is slowing us down in our key choke point: review --> merge. I believe that we are better off without it. |
It has been turned off for query-server. |
Thanks @niranjan94 Do you have admin rights to help solve #332 ? |
@cclauss nope. That isn't under my codacy account. |
As discussed in #349 (comment) @fossasia-bit generates a ton of superfluous messages that clutter the PR. It assigns PRs to their author which as far as I can tell is both redundant and useless. It then warns of conflicts which either echos information that GitHub has already provided or it is lying because there is no conflict. It tells you if tests fail but GitHub, Travis, and Codasy already provide that data in a more consumable way.
The text was updated successfully, but these errors were encountered: