more informative tweet text #331
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParthS007
reviewed
Nov 14, 2017
There was a problem hiding this comment.
Good work @sinAshish. But please follow the best practices while creating PR and PR title should be like Fixes # (issue reference) (changes by PR).
|
Please resolve conflicts. |
|
Not showing any conflicts in mine. |
|
Taken care in #363 |
|
closing with the reference to #363 |
Remorax
pushed a commit
to Remorax/query-server
that referenced
this pull request
Jan 14, 2018
Remorax
pushed a commit
to Remorax/query-server
that referenced
this pull request
Jan 14, 2018
* Fixes#283 UI changes (fossasia#309) * UI (fossasia#332) * Fixes#283 UI changes (fossasia#309) (fossasia#328) * Fixes#283 UI changes (fossasia#309) (fossasia#330) * Fixes#283 UI changes (fossasia#309) (fossasia#331)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #330
Checklist
masterbranch.Changes proposed in this pull request: