Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve our pytests #384

Closed
wants to merge 2 commits into from
Closed

Improve our pytests #384

wants to merge 2 commits into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Dec 10, 2017 •
edited
Loading

Confirms #383

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream master branch.
  • I have added necessary documentation (if appropriate)

Changes proposed in this pull request:

bhaveshAn
bhaveshAn reviewed Dec 10, 2017
View reviewed changes
Copy link
Member

@bhaveshAn bhaveshAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you resolve Codacy errors

@cclauss
Copy link
Contributor Author

cclauss commented Dec 10, 2017

The Codasy errors are caused by #332 which I do not have the administrative rights to resolve.

@cclauss cclauss mentioned this pull request Dec 10, 2017
Closed
3 tasks
@cclauss
Copy link
Contributor Author

cclauss commented Dec 10, 2017

Closed in favor of #384

@cclauss cclauss closed this Dec 10, 2017
@cclauss cclauss deleted the improve-pytests branch December 10, 2017 21:39
@cclauss cclauss restored the improve-pytests branch December 11, 2017 06:15
Remorax pushed a commit to Remorax/query-server that referenced this pull request Jan 14, 2018
@yashLadha @vaibhavsingh97
Fixes fossasia#374: Add custom font for badges (fossasia#384)
65a5450
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhaveshAn bhaveshAn bhaveshAn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cclauss @bhaveshAn