Added unit tests for better code coverage (#368) #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please resolve conflicts 😄 |
dilraj45
force-pushed
the
development
branch
5 times, most recently
from
c502cb7
to
5e563d9
Compare
cclauss
reviewed
Jan 13, 2018
.travis.yml
Outdated
| @@ -10,8 +10,8 @@ install: | |||
| before_script: | |||
| - flake8 . --count --max-complexity=15 --show-source --statistics | |||
| script: | |||
| - python app/server.py > /dev/null & | |||
| - pytest --capture=sys --showlocals | |||
There was a problem hiding this comment.
Why remove —showlocals? I find that option quite helpful.
There was a problem hiding this comment.
I will add the showlocals option. I guess, I overlooked this while fixing conflicts, apologies for that
Added dependency on mock in requirement.txt Updated server.py to use absolute imports Changed the invocation of server.py to 'python -m app.server' in .travis.yml
Remorax
pushed a commit
to Remorax/query-server
that referenced
this pull request
Jan 14, 2018
* Fixes fossasia#431 * Fixes fossasia#431
dilraj45
changed the title
Codecov Report
@@ Coverage Diff @@
## master #431 +/- ##
==========================================
+ Coverage 47.26% 91.06% +43.8%
==========================================
Files 17 28 +11
Lines 402 627 +225
==========================================
+ Hits 190 571 +381
+ Misses 212 56 -156
Continue to review full report at Codecov.
|
Added dependency on mock in requirement.txt Updated server.py to use absolute imports Changed the invocation of server.py to 'python -m app.server' in .travis.yml
mojeek.py. parsijoo.py, quora.py, yahoo.py, youtube.py (fossasia#368)
|
@bhaveshAn @vaibhavsingh97 Please review |
Added dependency on mock in requirement.txt Updated server.py to use absolute imports Changed the invocation of server.py to 'python -m app.server' in .travis.yml
mojeek.py. parsijoo.py, quora.py, yahoo.py, youtube.py (fossasia#368)
cclauss
approved these changes
Jan 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
masterbranch.Changes proposed in this pull request:
server.pyScreenshot of current coverage report
