-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document known problems with some plugins and ajax content #10447
Comments
PR 1/2 #10947 |
Can you test if this PR fixes one of both? |
Hi, did you already find some time to take a look again at this issue? Would be glad if you could give some feedback on this. |
Sure thing, just give me a couple of days and I'll give this PR a spin.
…On Mon, Mar 12, 2018 at 5:11 PM, Daniel Ruf ***@***.***> wrote:
Hi, did you already find some time to take a look again at this issue?
Would be glad if you could give some feedback on this.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#10447 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABhdExT_v1U6qk60-04hnZC5xGY5hQDrks5tdvKpgaJpZM4OfsLz>
.
--
-andrés
|
Awesome, let us know if you need any assistance. |
Hey Daniel, sorry for the delay. Got around to this last night, had to do a major update of Meteor and ran into some issues, want to wrap this up today -- but it seems the PR was deleted, and the one I should be testing is the one here: Is this correct? |
The PR is #10447 (comment) |
The PR was not deleted, just the branch. The one that you linked to is the new one, right. |
Great, will test this evening |
I'm having a bit of a hard time applying this pull request. I'm assuming I
need to clone foundation-sites (develop), and apply this mail-formatted
patch:
https://patch-diff.githubusercontent.com/raw/zurb/foundation-sites/pull/11077.patch
I'm using 'patch -Rp1 -i', and getting "Unreversed patch detected" for all
but one file.
Am I going about this the wrong way? Once patched, I need a little guidance
as to how to test (using zurb template, and npm installed foundation-sites.
…On Wed, Mar 21, 2018 at 10:08 AM, Daniel Ruf ***@***.***> wrote:
The PR was not deleted, just the branch. The one that you linked to is the
new one, right.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#10447 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABhdE8FVjhHNlDC2vtLVTuqph8ej4cfKks5tgmz9gaJpZM4OfsLz>
.
--
-andrés
|
Did you clone https://github.com/ncoden/foundation-sites and checkout the branch of the PR? |
Daniel, I noticed that this is now merged in with develop branch, I've pulled re-built and tested. Sticky is still not working for me. Please let me know if there is anything you'd like to me to do. My time has freed up and I am available. |
Please provide the steps that you took. |
I'm using zurb template, so within the project:
Afterwards the plugin does seem to init (attributes are updated on the element, and container element) but nothing happens. |
Yeah, same issue as I had before (haven't worked on this project for a while, so just getting back to it). After init, if I manually use the |
cc @ncoden |
We have improved that in Foundation v6.6. As there are no codepen or any steps to reproduce it is hard to test. We are closing this issue due to this. If there are still issues in the latest release, please let us know. |
After spending hours trying to troubleshoot Sticky (and Magellan) I find that the plugins are practically non-functional with ajax content (See: #9047 and it's related issues).
Please properly document this (it's a known problem since July 2016) in Sticky, Magellan, and any other plugins that might be affected in order for developers to be aware. This is especially important for your meteor-README.md file as these plugins won't be compatible with Meteor (just like #9919)
I've bundled issues with Magellan here as well, since both exhibit same non-functionality in Meteor, and both depend on content position/scroll.
The text was updated successfully, but these errors were encountered: