Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document known problems with some plugins and ajax content #10447

Closed
in0ni opened this issue Jul 21, 2017 · 17 comments
Closed

Document known problems with some plugins and ajax content #10447

in0ni opened this issue Jul 21, 2017 · 17 comments

Comments

@in0ni
Copy link

in0ni commented Jul 21, 2017

After spending hours trying to troubleshoot Sticky (and Magellan) I find that the plugins are practically non-functional with ajax content (See: #9047 and it's related issues).

Please properly document this (it's a known problem since July 2016) in Sticky, Magellan, and any other plugins that might be affected in order for developers to be aware. This is especially important for your meteor-README.md file as these plugins won't be compatible with Meteor (just like #9919)

I've bundled issues with Magellan here as well, since both exhibit same non-functionality in Meteor, and both depend on content position/scroll.

@DanielRuf
Copy link
Contributor

PR 1/2 #10947

@DanielRuf
Copy link
Contributor

Can you test if this PR fixes one of both?

@DanielRuf
Copy link
Contributor

Hi, did you already find some time to take a look again at this issue? Would be glad if you could give some feedback on this.

@in0ni
Copy link
Author

in0ni commented Mar 14, 2018 via email

@DanielRuf
Copy link
Contributor

Sure thing, just give me a couple of days and I'll give this PR a spin.

Awesome, let us know if you need any assistance.

@in0ni
Copy link
Author

in0ni commented Mar 21, 2018

Hey Daniel, sorry for the delay.

Got around to this last night, had to do a major update of Meteor and ran into some issues, want to wrap this up today -- but it seems the PR was deleted, and the one I should be testing is the one here:
#11077

Is this correct?

@DanielRuf
Copy link
Contributor

The PR is #10447 (comment)

@DanielRuf
Copy link
Contributor

The PR was not deleted, just the branch. The one that you linked to is the new one, right.

@in0ni
Copy link
Author

in0ni commented Mar 21, 2018

Great, will test this evening

@in0ni
Copy link
Author

in0ni commented Mar 22, 2018 via email

@DanielRuf
Copy link
Contributor

Did you clone https://github.com/ncoden/foundation-sites and checkout the branch of the PR?

@in0ni
Copy link
Author

in0ni commented Mar 27, 2018

Daniel,

I noticed that this is now merged in with develop branch, I've pulled re-built and tested. Sticky is still not working for me. Please let me know if there is anything you'd like to me to do. My time has freed up and I am available.

@DanielRuf
Copy link
Contributor

Please provide the steps that you took.

@in0ni
Copy link
Author

in0ni commented Mar 27, 2018

I'm using zurb template, so within the project:

cd node_modules
mv foundation-sties foundation-sites.bup
git clone https://github.com/zurb/foundation-sites.git (develop already checked out)
cd ../
rm -rf dist
npm run build

Afterwards the plugin does seem to init (attributes are updated on the element, and container element) but nothing happens.

@in0ni
Copy link
Author

in0ni commented Mar 27, 2018

Yeah, same issue as I had before (haven't worked on this project for a while, so just getting back to it).

After init, if I manually use the _calc method it works:
$('#element').foundation('_calc', true);

@DanielRuf
Copy link
Contributor

cc @ncoden

@DanielRuf DanielRuf assigned DanielRuf and unassigned DanielRuf Mar 30, 2018
@DanielRuf
Copy link
Contributor

We have improved that in Foundation v6.6. As there are no codepen or any steps to reproduce it is hard to test.

We are closing this issue due to this. If there are still issues in the latest release, please let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants