Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abide accessibility #10699

Merged
merged 14 commits into from
Jan 30, 2018
Merged

Abide accessibility #10699

merged 14 commits into from
Jan 30, 2018

Commits on Oct 5, 2017

  1. Implemented accessibility for Abide. 

    Set aria-invalid attribute when something is not valid, see [here (Mailinglist)](http://lists.w3.org/Archives/Public/public-pfwg/2015Jul/0031.html) and [here (Spec)](https://www.w3.org/TR/wai-aria-1.1/#aria-invalid).
    @Owlbertz
    Owlbertz committed Oct 5, 2017
    Configuration menu
    Copy the full SHA
    51a2558 View commit details
    Browse the repository at this point in the history

  2. Improved accessibility of Abide page. 

    Added aria-onerrormessage attributes where needed. See [here (Spec)](https://www.w3.org/TR/wai-aria-1.1/#aria-errormessage).
Fixed multiple elements having the same ID.
    @Owlbertz
    Owlbertz committed Oct 5, 2017
    Configuration menu
    Copy the full SHA
    dfae510 View commit details
    Browse the repository at this point in the history

  3. Added unittests for aria-invalid in Abide.

    @Owlbertz
    Owlbertz committed Oct 5, 2017
    Configuration menu
    Copy the full SHA
    3e512b9 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2018

  1. docs: improve accessibility of abide examples 

    Changes:
* rename IDs of inputs/descriptors
* add `aria-describedby` and `aria-live="assertive` when required
    @ncoden
    ncoden committed Jan 8, 2018
    Configuration menu
    Copy the full SHA
    835cf04 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2018

  1. feat: add [aria-live] on [data-abide-error] on form validation 

    Add Abide option: `globalErrorAriaLevel`
    @ncoden
    ncoden committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    07b2d76 View commit details
    Browse the repository at this point in the history

  2. feat: automatically add [aria-describedby] and [for] attributes in Abide

    @ncoden
    ncoden committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    88abca7 View commit details
    Browse the repository at this point in the history

  3. feat: add a11yAttributes option on Abide to disable a11y attribute … 

    …insertion
    @ncoden
    ncoden committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    d1acd32 View commit details
    Browse the repository at this point in the history

  4. feat: set [aria-live] on Abide global erros on init

    @ncoden
    ncoden committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    f55efd5 View commit details
    Browse the repository at this point in the history

  5. docs: add basic doc about a11y attributes in Abide

    @ncoden
    ncoden committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    6cf6619 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2018

  1. test: add unit tests for Abide.addA11yAttributes()

    @ncoden
    ncoden committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    32efbc2 View commit details
    Browse the repository at this point in the history

  2. test: add unit test for Abide.addGlobalErrorA11yAttributes()

    @ncoden
    ncoden committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    8e7fa06 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2018

  1. test: add visual test for Abide accessibility

    @ncoden
    ncoden committed Jan 20, 2018
    Configuration menu
    Copy the full SHA
    edf21d2 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2018

  1. fix: fix side-effect of jQuery .filter() in Abide.addA11yAttributes 

    Prevent jQuery `.filter()` to mutate the context object.
    @ncoden
    ncoden committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    c6a6906 View commit details
    Browse the repository at this point in the history

  2. feat: add [role=label] to all form errors in Abide

    @ncoden
    ncoden committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    c6e4b56 View commit details
    Browse the repository at this point in the history