Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix uncentered last column on Float Grid #9952 #11115

Merged
merged 4 commits into from
Apr 5, 2018
Merged

fix: fix uncentered last column on Float Grid #9952 #11115

merged 4 commits into from
Apr 5, 2018

Commits on Mar 31, 2018

  1. fix: fix uncenter for last column in Float Grid foundation#9952 

    Closes foundation#9952
See foundation#9952 (comment)
    @ncoden
    ncoden committed Mar 31, 2018
    Configuration menu
    Copy the full SHA
    50e7dab View commit details
    Browse the repository at this point in the history

  2. refactor: add "default" position to grid-column-positioning to hand… 

    …le float position

Handle all the float positioning of Float Grid in the same mixin. This also makes the "last column" selector used only in this mixin.
    @ncoden
    ncoden committed Mar 31, 2018
    Configuration menu
    Copy the full SHA
    fa07c03 View commit details
    Browse the repository at this point in the history

  3. tests: add visual test for Float Grid uncentered columns

    @ncoden
    ncoden committed Mar 31, 2018
    Configuration menu
    Copy the full SHA
    9429539 View commit details
    Browse the repository at this point in the history

  4. fix: fix last column uncentering with edge align disabled in Float Grid 

    Ensure to uncenter the last column with the right specificity even when `$grid-column-align-edge`  is disabled.
    @ncoden
    ncoden committed Mar 31, 2018
    Configuration menu
    Copy the full SHA
    a8f850e View commit details
    Browse the repository at this point in the history